Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PG-1457 Key management funcs renaming #126

Open
wants to merge 17 commits into
base: release-17.4
Choose a base branch
from
Open

PG-1457 Key management funcs renaming #126

wants to merge 17 commits into from

Conversation

artemgavrilov
Copy link
Collaborator

@artemgavrilov artemgavrilov commented Mar 12, 2025 •
edited
Loading

PG-1457

Description

  1. All key provider management functions have scope in the name (database or global)
  2. Key management function have key provider in the name (using_database_key_provider or using_global_key_provider)
  3. Other scope dependent functions have scope in the name

Links

@it-percona-cla
Copy link

it-percona-cla commented Mar 12, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@artemgavrilov artemgavrilov force-pushed the PG-1457-key-management-funcs-renaming branch from 1afe9e2 to 1a2a757 Compare March 14, 2025 09:51
@artemgavrilov artemgavrilov changed the base branch from TDE_REL_17_STABLE to release-17.4 March 14, 2025 09:51
@artemgavrilov artemgavrilov marked this pull request as ready for review March 15, 2025 13:48
@mohitj1988
Copy link

mohitj1988 commented Mar 15, 2025 •
edited
Loading

Hi @artemgavrilov - Few more possible renaming after discussing with @dutow
pg_tde_list_all_key_providers → pg_tde_list_all_local_key_providers
pg_tde_add_key_provider_kmip -> pg_tde_add_local_key_provider_kmip
pg_tde_add_key_provider_vault_v2 -> pg_tde_add_local_key_provider_vault_v2
pg_tde_add_key_provider_file -> pg_tde_add_local_key_provider_file

@artemgavrilov
Copy link
Collaborator Author

Hold on with reviews, I'm adding more things

@artemgavrilov artemgavrilov force-pushed the PG-1457-key-management-funcs-renaming branch from 2de9a34 to 66db9c3 Compare March 18, 2025 14:16
@artemgavrilov artemgavrilov requested a review from jeltz March 19, 2025 10:23
nastena1606
nastena1606 reviewed Mar 19, 2025
View reviewed changes
contrib/pg_tde/documentation/docs/functions.md

Creates or rotates the global principal key using the specified key provider. Use this function to set a principal key for WAL encryption.
Creates or rotates the server principal key using the specified global key provider. Use this function to set a principal key for WAL encryption.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the server key? Maybe rewrite to what this key is used for? For WAL encryption, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now only for WAL encryption, but in future it may be used for something else. I guess for system tables encryption. In general its purpose to encrypt entities that has server scope availability.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok thanks, I believe it's time to explain existing scopes and their usage. In a separate PR most likely

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely agree

@nastena1606 nastena1606 self-requested a review March 19, 2025 13:01
@artemgavrilov artemgavrilov mentioned this pull request Mar 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dutow dutow dutow approved these changes

@nastena1606 nastena1606 nastena1606 approved these changes

@dAdAbird dAdAbird Awaiting requested review from dAdAbird dAdAbird is a code owner

@jeltz jeltz Awaiting requested review from jeltz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@artemgavrilov @it-percona-cla @mohitj1988 @dutow @nastena1606