PG-1416, PG-829 Merge the map and keydata files #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeltz
force-pushed
the
tde/merge-key-files
branch
3 times, most recently
from
06af08b to
c1cc680
Compare
If we have a lot of keys this could be a bit of memory.
This simplifies the API of the function.
This is done to simplify a future refactoring of the file.
A function which does two mostly unrelated things based on a boolean argument is hard to read and reason about.
We never took advantage of that the relation keys were stored in two different files, one for the RelFileNumber and flags and one for the actual keys so this just complicated the code for almost no gain. Bumps the version of the file format.
jeltz
force-pushed
the
tde/merge-key-files
branch
from
c1cc680 to
1c42017
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We never took advantage of that the relation keys were stored in two
different files, one for the RelFileNumber and flags and one for the
actual keys so this just complicated the code for almost no gain.
Bumps the version of the file format.
This will make it less painful to add new features to the file format like checksums.