PoC: PG-1392 Encrypt all relation forks #96
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeltz
force-pushed
the
tde/encrypt-all-forks
branch
from
15c1833 to
2c4083a
Compare
jeltz
changed the title
jeltz
force-pushed
the
tde/encrypt-all-forks
branch
from
2c4083a to
5db59f3
Compare
It is unclear to me why we stopped encrypting the FSM and visibility map forks in commit e514ac5 which sadly does not explain why we stopped doing so. Both of them leak metadata that we do not have to. Especially once we also encrypt the catalogs.
jeltz
force-pushed
the
tde/encrypt-all-forks
branch
from
5db59f3 to
049c28f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is unclear to me why we stopped encrypting the FSM and visbility map forks in commit e514ac5 which sadly does not explain why we stopped doing so. Both of them leak metadata that we do not have to. Especially once we also encrypt the catalogs.