Fix memory deallocation #138
Open
+211
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensure proper string termination in `get_function_sig` by adding `\0` for correct `strlen` usage. - Pass `Proc` struct to `async_init` to enable binary cleanup when the Port is closed. - Invoke `hb_beamr:stop(WASM)` in all tests to trigger garbage collection. - Free memory allocated for stub functions and remove stubs when the Port is closed. - Extend `LoadWasmReq` struct to store the list of stubs.
oltarasenko
force-pushed
the
mem_cleans
branch
from
898ee0c to
57747b9
Compare
oltarasenko
force-pushed
the
mem_cleans
branch
from
57747b9 to
6ab2659
Compare
Prior to this change, deallocating current_args in hb_beamr could lead to segfaults due to uninitialized fields in the allocated structure. This commit initializes the Proc struct with NULL values, ensuring safe deallocation of resources.
oltarasenko
force-pushed
the
mem_cleans
branch
from
62eca83 to
5f0fef7
Compare
|
Hi @samcamwilliams, I have made quite a few modifications to how we allocate and deallocate resources. Besides this, I have made a test that helps visualize how resources leak when a given number of iterations is done. In the tests below I investigate the driver allocation memory when we perform 1M requests to WASM runtime. In both cases nodes have some basic memory usage visible in Activity Monitor (and it's approximately 130Mb). Before the fix (main) In the result, we see that the node started to consume 2.79 GB of RAM. After the fix (current branch) In the result, we see that the node started to consume 460 Mb of RAM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_function_sigby adding
\0for correctstrlenusage.Procstruct toasync_initto enable binary cleanup whenthe Port is closed.
hb_beamr:stop(WASM)in all tests to trigger garbage collection.when the Port is closed.
LoadWasmReqstruct to store the list of stubs.