A few fixes for JIT in Ivy #7
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ces (angular#23584) Since `versionedFiles` behaves in the exact same way as `files`, there is no reaason to have both. Users should use `files` instead. This commit deprecates the property and prints a warning when coming across an asset-group that uses it. It should be completely removed in a future version. Note, it has also been removed from the default `ngsw-config.json` template in angular/devkit#754. PR Close angular#23584
The developer doc mentions but doesn't link to BAZEL.md. Add link and fix capitalization. PR Close angular#22940
Update the example to match the description preceding it, which refers to the use of the error method and ErrorEvent rather than the flush method with a non-2xx status as shown previously. PR Close angular#22844
Angular Conf Australia 2018 will be held at June 22 in Melbourne, Australia! https://www.angularconf.com.au/ PR Close angular#22929
… with the styleguide (angular#23832) PR Close angular#23832
are are -> are PR Close angular#23990
Previously, it was possible to set the live-example title as content in
the `<live-example>` element. This relied on our custom loader
functionality that extracted the content from the DOM element before
passing it to the Angular compiler and stored it on a property for later
retrieval.
Since we switched to custom elements (and got rid of the custom loader),
the property is no longer populated with the contents. As a result, many
live examples show the default title ("live example") instead of the one
specified as content.
This commit fixes it by projecting the content into an invisible node
for later retrieval (similar to what we do in other components, such as
the `CodeExampleComponent`).
PR Close angular#23960
…#23960) With `plnkrs`, we used to choose a different plnkr mode (normal vs embedded) based on the size of the screen. This affected the layout of the plnkr page ("embedded" plnkr mode was usable on small screens, while "normal" mode wasn't). This is not to be confused with the live-example mode we use today to determine whether the live-example should be a link (that open StackBlitz on a new page) or embedded into the document (using an iframe). Since we no longer need to change the live-example URL based on the screen size, there is no need to listen for rezise events on Window. The necessary properties can be computed once and certain variables are obsolete. PR Close angular#23960
…nload (angular#23948) Closes angular#23060 PR Close angular#23948
This commit adds a mechanism by which the @angular/core annotations for @component, @Injectable, and @NgModule become decorators which, when executed at runtime, trigger just-in-time compilation of their associated types. The activation of these decorators is configured by the ivy_switch mechanism, ensuring that the Ivy JIT engine does not get included in Angular bundles unless specifically requested. PR Close angular#23833
"Made" doesn't make sense (redoing and closing angular#23940) PR Close angular#23998
….serviceWorker (angular#21231) PR Close angular#21231
This was erroneously committed into master, when it was really only supposed to demo what the pages might look like. PR Close angular#24000
This commit adds new link disambiguators that mean that more code links can be generated automatically in a sensible way. The best example is the use of properties within class, interface and enum documentation. PR Close angular#24000
It is cleaner and simpler to use just a straightforward link. PR Close angular#24000
The overview of the decorator options is now a table. The detailed description of each option is now a full section. PR Close angular#24000
…ngular#24000) The sections such as methods and decorator options are already headed by a H3 heading so we need to map the H3 headings in the API doc source down to H4 headings. This commit includes general heading mapping functionality accessible via the `marked` Nunjucks filter. PR Close angular#24000
This heading is too high for the section because the method name is a H3 but it cannot be a H4 because usage notes may contain H4 headings. PR Close angular#24000
* Code anchors should inherit the font size from their container * Table headings should align with content PR Close angular#24000
We should not include the package path in the inherited from heading for decorator API docs PR Close angular#24000
This change adds Github edit and view links to methods and decorator options. It is possible to add these to properties also but the UI is rather tight as these are displayed in a table. PR Close angular#24000
Includes a fix for out-of-memory condition which caused this to be reverted yesterday. PR Close angular#24512
…ngular#24507) When creating content queries from a directive on an element we need to take into account existing view queries. The same element can be reported to both content and view queries so freshly created content queries must be combined with pre-existing view queries. PR Close angular#24507
…4479) At runtime in JIT mode, when the compiler writes a reference to a symbol that symbol is resolved through a symbol table named angularCoreEnv in render3/jit/environment. Previously, this symbol table was not kept up-to-date with the Ivy instruction set and the names of symbols the compiler could reference. This change brings the symbol table in sync, and also adds a test that verifies every symbol the compiler can reference is available at runtime in the symbol table. PR Close angular#24479
clang-format (on mac) has taken a disliking to this particular line, and rewrites one of the ɵ characters to an invalid Unicode sequence. PR Close angular#24479
…24427) This change supports compilation of components, directives, and modules within ngtsc. Support is not complete, but is enough to compile and test //packages/core/test/bundling/todo in full AOT mode. Code size benefits are not yet achieved as //packages/core itself does not get compiled, and some decorators (e.g. @input) are not stripped, leading to unwanted code being retained by the tree-shaker. This will be improved in future commits. PR Close angular#24427
Injector was incorrectly returning instance from parent injector even when `@Self` was specified. PR Close angular#24520
inject() was changed in da31db7 to not take a default value parameter, so injectable_compiler_2 should not request the use of one when using inject().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Optionalinjection.inputsandoutputsin decorator metadata.