Add test for ngcc #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$ bazel test //packages/compiler-cli/test/ngcc This commit adds ngcc_spec.ts which sets up a test environment that includes ngc-compiled versions of @angular/core and @angular/common, and invokes ngcc against @angular/common. It's a starting point for additional ngcc testing.
| @@ -10,6 +10,7 @@ ts_library( | |||
| deps = [ | |||
| "//packages/compiler", | |||
| "//packages/compiler-cli", | |||
There was a problem hiding this comment.
I removed these two deps as they are not needed for testing ngcc right now and it makes the compilation more compilicated[sic]!
gkalpak
reviewed
Jun 19, 2018
| srcs = glob([ | ||
| "*.ts", |
There was a problem hiding this comment.
Is this necessary? Doesn't **/*.ts match top-level files as well?
There was a problem hiding this comment.
I don't think so. Perhaps it ensures that the top level source files are included first?
| @@ -18,7 +19,8 @@ jasmine_node_test( | |||
| name = "ngcc", | |||
| bootstrap = ["angular/tools/testing/init_node_no_angular_spec.js"], | |||
| data = [ | |||
| "//packages/compiler-cli/test/ngcc/fake_core:npm_package", | |||
| "//packages/core:npm_package", | |||
| "//packages/common:npm_package", | |||
There was a problem hiding this comment.
@alxhub - including these dependencies makes the incremental much slower as they appear to be somewhat rebuilt every time... in particular the Angular Compiler seems to be running on them every build. This means that ~800 targets are built rather than ~13.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a Bazel test
ngcc_spec.tswhich verifies functionality ofngcc.