Skip to content

Remove PHP 8.4.* deprecations #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
@@ -15,8 +15,8 @@ jobs:

strategy:
matrix:
php-version: ['7.4', '8.2']
symfony-version: ['4.4', '5.3', '5.4', '6.4', '7.0']
php-version: ['7.4', '8.4']
symfony-version: ['5.4', '6.4', '7.4']
coverage: ['none']
exclude:
- php-version: '7.4'
@@ -28,16 +28,10 @@ jobs:
symfony-version: '5.4'
coverage: xdebug
- php-version: '8.1'
symfony-version: '6.2'
coverage: 'none'
- php-version: '8.1'
symfony-version: '6.1'
coverage: 'none'
- php-version: '8.1'
symfony-version: '6.3'
symfony-version: '6.4'
coverage: 'none'
- php-version: '8.2'
symfony-version: '6.3'
symfony-version: '6.4'
coverage: 'none'

steps:
2 changes: 1 addition & 1 deletion Command/BaseRabbitMqCommand.php
Original file line number Diff line number Diff line change
@@ -12,7 +12,7 @@ abstract class BaseRabbitMqCommand extends Command
*/
protected $container;

public function setContainer(ContainerInterface $container = null): void
public function setContainer(?ContainerInterface $container = null): void
{
$this->container = $container;
}
2 changes: 1 addition & 1 deletion DataCollector/MessageDataCollector.php
Original file line number Diff line number Diff line change
@@ -21,7 +21,7 @@ public function __construct($channels)
$this->data = [];
}

public function collect(Request $request, Response $response, \Throwable $exception = null)
public function collect(Request $request, Response $response, ?\Throwable $exception = null)
{
foreach ($this->channels as $channel) {
foreach ($channel->getBasicPublishLog() as $log) {
2 changes: 1 addition & 1 deletion RabbitMq/AMQPConnectionFactory.php
Original file line number Diff line number Diff line change
@@ -41,7 +41,7 @@ class AMQPConnectionFactory
public function __construct(
$class,
array $parameters,
ConnectionParametersProviderInterface $parametersProvider = null
?ConnectionParametersProviderInterface $parametersProvider = null
) {
$this->class = $class;
$this->parameters = array_merge($this->parameters, $parameters);
2 changes: 1 addition & 1 deletion RabbitMq/BaseAmqp.php
Original file line number Diff line number Diff line change
@@ -63,7 +63,7 @@ abstract class BaseAmqp
* @param AMQPChannel|null $ch
* @param string|null $consumerTag
*/
public function __construct(AbstractConnection $conn, AMQPChannel $ch = null, $consumerTag = null)
public function __construct(AbstractConnection $conn, ?AMQPChannel $ch = null, $consumerTag = null)
{
$this->conn = $conn;
$this->ch = $ch;
2 changes: 1 addition & 1 deletion RabbitMq/BatchConsumer.php
Original file line number Diff line number Diff line change
@@ -81,7 +81,7 @@ class BatchConsumer extends BaseAmqp implements DequeuerInterface
/**
* @param \DateTime|null $dateTime
*/
public function setGracefulMaxExecutionDateTime(\DateTime $dateTime = null)
public function setGracefulMaxExecutionDateTime(?\DateTime $dateTime = null)
{
$this->gracefulMaxExecutionDateTime = $dateTime;
}
2 changes: 1 addition & 1 deletion RabbitMq/Consumer.php
Original file line number Diff line number Diff line change
@@ -234,7 +234,7 @@ protected function isRamAlmostOverloaded()
/**
* @param \DateTime|null $dateTime
*/
public function setGracefulMaxExecutionDateTime(\DateTime $dateTime = null)
public function setGracefulMaxExecutionDateTime(?\DateTime $dateTime = null)
{
$this->gracefulMaxExecutionDateTime = $dateTime;
}
2 changes: 1 addition & 1 deletion RabbitMq/Producer.php
Original file line number Diff line number Diff line change
@@ -51,7 +51,7 @@ protected function getBasicProperties()
* @param array $additionalProperties
* @param array $headers
*/
public function publish($msgBody, $routingKey = null, $additionalProperties = [], array $headers = null)
public function publish($msgBody, $routingKey = null, $additionalProperties = [], ?array $headers = null)
{
if ($this->autoSetupFabric) {
$this->setupFabric();