-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow psr/container v2 #1206
Allow psr/container v2 #1206
Conversation
Is this something enqueue can support? We're hoping it doesn't require a major version bump since it's compatible. |
Looking at the codebase changes in the package in question (php-fig/container@1.1.1...master) there should be no need for a major version bump. |
Indeed there isn't. Just need someone to merge this and do a new release :) |
News for this? |
@makasim Could you review this please? |
could you sync with the latest master branch ? there are some fixes for the tests. Would be good to merge it once it green |
Done |
Ping |
There is a failed CI job |
Well I have no idea how this change could be affecting that test. Can you just try re-running the testsuite? Could be a flaky test or an issue with the CI environment. |
I've tried, no luck. |
This is the failure. Does it look familiar to you?
|
@makasim We cannot find any connection to the changes in psr/container v2 for this test. I'm not sure what you expect us to do to resolve this. Can we run the tests again? |
I re-run the tests. it might very well be not related to your changes. though CI must be green before I can merge otherwise it would soon go out of control. |
We appreciate that need. I had a hard time following that specific test so I wasn't sure how to help. |
That's indeed a wired one. Recently there was a PR #1211 that addressed issues with the tests. And it was green. |
This appears to pass now. Hope that's enough. |
No description provided.