Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #1237

Merged
merged 4 commits into from
Feb 8, 2022
Merged

Fix CI #1237

merged 4 commits into from
Feb 8, 2022

Conversation

jdecool
Copy link
Contributor

@jdecool jdecool commented Feb 3, 2022

The CI is red and this PR fix it.

There's 3 problems:

  • Thruway docker image (docker/thruway/Dockerfile) use voryx/thruway which also uses thruway/client which is not currently compatible with PHP 8.0. So before the library is compatible, I've fixed the PHP version to 7.4 for this container.
  • docker/Dockerfile image is executed with PHP 7.4 & 8.0 and use PEAR to install some extensions. As PR is not fully compatible with PHP 8.0, required dependencies are compiled.
  • enqueue libraries depends on thruway/pawl-transport which depend on ratchet/pawl (^0.3.1). The 0.3.x version doesn't support guzzlehttp/psr7 2.x branch. So we needs to restrict guzzlehttp/psr7 to 1.x branch

@jdecool jdecool changed the title Force makasim/nginx-php-fpm for thruway Docker service Fix CI Feb 3, 2022
@jdecool jdecool marked this pull request as ready for review February 3, 2022 21:27
@jdecool
Copy link
Contributor Author

jdecool commented Feb 4, 2022

Strange. I've tested it on my fork before and it was green https://github.com/jdecool/enqueue-dev/pull/1/checks

@jdecool
Copy link
Contributor Author

jdecool commented Feb 4, 2022

Could you retry the failed job ?

@makasim makasim merged commit fa2a406 into php-enqueue:master Feb 8, 2022
@makasim
Copy link
Member

makasim commented Feb 8, 2022

Thanks!

@jdecool jdecool deleted the fix-ci branch February 8, 2022 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants