-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expire type not long unexpected #1783
Comments
michael-grunder
added a commit
that referenced
this issue
Aug 18, 2020
michael-grunder
added a commit
that referenced
this issue
Aug 18, 2020
I'm not sure how relaxed the typing should be here, but I updated the logic to accept a long or a numeric string, while not allowing something like this: $fp = fopen('/tmp/test.txt', 'a');
$obj_r->set('foo', 'bar', $fp); // PHP's zval_get_long will return the integer file descriptor |
michael-grunder
added a commit
that referenced
this issue
Aug 25, 2020
michael-grunder
added a commit
that referenced
this issue
Aug 30, 2020
michael-grunder
added a commit
that referenced
this issue
Aug 30, 2020
Relax requirements on set's expire argument See: #1783
Closing as this has been merged. Let me know if you're still having issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected behaviour
set(key, value, "3") and set(key, value, ["ex" => "3"]) both success
Actual behaviour
set(key, value, "3") failure but set(key, value, ["ex" => "3"]) success
I'm seeing this behaviour on
Steps to reproduce, backtrace or example script
$redis = new phpredis()
....
$result = $redis->set(key, value, "3")
//$result is failure
The text was updated successfully, but these errors were encountered: