-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clonkk devel toc generation #3
Conversation
Remove more commented code
As mentioned, I like this approach (based on a simple detailsThe design I would keep from #2 (and would add on top of this) is:
let toc = newToc("books"):
entry("Introduction", "index")
entry("Basics", "basics/index"):
entry("Plotting", basics/data_visualization")
...
|
Yeah, a template DSL is nice to have.
I'm not against JSON, but I'm not sure I understand how it is different from the mustache approach (I'm not well versed in web stuff). If you think it's necessary and/or easier moving forward, go ahead. Generating nested JSON from a
Repo being both a nimble package and a template was more or less the same thing in mind. We'll also probably need to split procs and type definition into multiple files and rename some file, but this is polishing that can be done later.
I think we can go ahead merging this as it fixed the API, and we'll improve the rest as we go along. |
Well JSON is just used an on disk format to pass it from the It seems we agree on all the rest! 😄 |
and thanks for this! |
This PR echo the discussion at #2
TODO : remove generated toc.mustache