Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix for header stats #25

Merged
merged 1 commit into from
Mar 31, 2021
Merged

Bugfix for header stats #25

merged 1 commit into from
Mar 31, 2021

Conversation

JMMackenzie
Copy link
Member

A minor fix; one of the stats in the header was reported incorrectly.

@JMMackenzie JMMackenzie requested a review from elshize March 30, 2021 23:55
@elshize
Copy link
Member

elshize commented Mar 31, 2021

This is because not all the posting lists are necessarily in the exported file, right?

@JMMackenzie
Copy link
Member Author

This is because not all the posting lists are necessarily in the exported file, right?

Actually, this is just a simple bug. The total_terms_in_collection is meant to capture the total number of terms (the sum of frequencies of all postings, or, the sum of the document lengths, whichever way you want to look at it). We were passing in something else by accident, I presume.

@elshize
Copy link
Member

elshize commented Mar 31, 2021

Oh, ok, got it. It's a bit misleading field name to me, but can't do much about that.

@elshize elshize merged commit 694caf0 into master Mar 31, 2021
@elshize elshize deleted the fix-header branch March 31, 2021 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elshize elshize elshize approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JMMackenzie @elshize