Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporary_Directory is not in pisa namespace #419

Closed
elshize opened this issue Jun 23, 2020 · 0 comments · Fixed by #489
Closed

Temporary_Directory is not in pisa namespace #419

elshize opened this issue Jun 23, 2020 · 0 comments · Fixed by #489
Labels
bug Something isn't working

Comments

@elshize
Copy link
Member

elshize commented Jun 23, 2020

We should define it in pisa namespace, and while we're at it, remove the underscore from the name.
@elshize elshize added the bug Something isn't working label Jun 23, 2020
elshize added a commit that referenced this issue Nov 10, 2022
@elshize
Move TemporaryDirectory to pisa namespace (#419)
f55ffb0 
Temporary_Directory is renamed to TemporaryDirectory and moved inside
pisa namespace. Implementations are moved to a separate cpp file.
@elshize elshize mentioned this issue Nov 10, 2022
Merged
elshize added a commit that referenced this issue Nov 10, 2022
@elshize
Move TemporaryDirectory to pisa namespace (#419)
9be6160 
Temporary_Directory is renamed to TemporaryDirectory and moved inside
pisa namespace. Implementations are moved to a separate cpp file.
elshize added a commit that referenced this issue Nov 14, 2022
@elshize
Move TemporaryDirectory to pisa namespace (#419)
2f47ed7 
Temporary_Directory is renamed to TemporaryDirectory and moved inside
pisa namespace. Implementations are moved to a separate cpp file.
elshize added a commit that referenced this issue Nov 14, 2022
@elshize
Move TemporaryDirectory to pisa namespace (#419) (#489)
178f3b6 
Temporary_Directory is renamed to TemporaryDirectory and moved inside
pisa namespace. Implementations are moved to a separate cpp file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move TemporaryDirectory to pisa namespace (#419) pisa-engine/pisa
1 participant
@elshize