cppcoreguidelines-pro-type-member-init

[elshize]

• cppcoreguidelines-pro-type-member-init
• readability-container-size-empty

[amallia]

Yes I know that. I think it was not necessary as it will be default constructed, but I might be wrong. Anyway it won’t hurt, that’s why I merged it

On Thu, 26 Mar 2020 at 22:06, Michał Siedlaczek ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In include/pisa/sequence/indexed_sequence.hpp <#349 (comment)>: > @@ -138,7 +138,7 @@ struct indexed_sequence { } private: - index_type m_type; + index_type m_type{}; It calls default constructor. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#349 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACFDRVA24CFWZUDU2OP34YLRJO7UHANCNFSM4LTWLHZQ> .

-- Sent from Gmail Mobile

[elshize]

I believe it's not initialized because it's enum so it acts like an integer, and primitives are not initialized by default. So to be more precise, {} doesn't really call default constructor but rather is an aggregate initializer whose rules are just complicated.

But the bottom line is that clang-tidy complained about it :)