Skip to content

Fix variable name and change tests to use MemorySource #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2020

Conversation

elshize
Copy link
Member

@elshize elshize commented Jun 23, 2020

No description provided.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@elshize elshize added the bug Something isn't working label Jun 23, 2020
@elshize elshize requested a review from amallia June 23, 2020 14:00
@elshize elshize self-assigned this Jun 23, 2020
@codecov
Copy link

codecov bot commented Jun 23, 2020

Codecov Report

Merging #420 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #420      +/-   ##
==========================================
+ Coverage   92.42%   92.48%   +0.06%     
==========================================
  Files          91       91              
  Lines        4921     4925       +4     
==========================================
+ Hits         4548     4555       +7     
+ Misses        373      370       -3     
Impacted Files Coverage Δ
include/pisa/wand_data.hpp 62.50% <ø> (ø)
include/pisa/block_freq_index.hpp 96.61% <100.00%> (+0.11%) ⬆️
include/pisa/freq_index.hpp 98.38% <100.00%> (+0.05%) ⬆️
include/pisa/mappable/mapper.hpp 85.71% <0.00%> (+3.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dde6095...d86ceff. Read the comment docs.

@elshize elshize requested a review from JMMackenzie June 24, 2020 11:05
@amallia amallia merged commit 9f62d6d into master Jun 24, 2020
@amallia amallia deleted the memory-source-init-name branch June 24, 2020 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants