Skip to content

MetaMask switch network banner (MORE FIXES) #1368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2024

Conversation

Steedie
Copy link
Contributor

@Steedie Steedie commented May 2, 2024

What

  1. Changed banner from relative to fixed.
  2. Moved the banner to the bottom of the screen.
  3. Added a close/hide button to the banner.
  4. Added slight blur effect.

Screenshot 2024-05-02 112316
Screenshot 2024-05-02 112343

Why

  1. relative caused the rest of the UI to be pushed down in most cases.
  2. Jimmy suggested moving it to the bottom of the screen. Now that it's using fixed, it overlays the rest of the UI. This is a problem when the banner is at the top of the screen because it overlays the Account Settings button. As it's at the bottom of the screen, it doesn't block the more important things like that, and zone info etc.
  3. Since it can still block some buttons, I think it makes sense to provide an option to hide the banner without being forced to switch networks.

@ldunnplaymint ldunnplaymint merged commit 276dd6c into main May 2, 2024
3 checks passed
@ldunnplaymint ldunnplaymint deleted the metamask-banner-more-fixes branch May 2, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants