Skip to content

Zone traits fix #1372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 2, 2024
Merged

Zone traits fix #1372

merged 3 commits into from
May 2, 2024

Conversation

Steedie
Copy link
Contributor

@Steedie Steedie commented May 2, 2024

What

  • There was a bug in the previous Zones721.sol code which messed up most of the trait values. Whoops!
    The relevant functions are now passed the tokenId as a parameters instead of using the latest minted zone's ID

  • Zones.t.sol test_mint has been updated to mint 100 zones, and give you the output for zones 1 and 42. The expected output after running forge test -vvv in ds/contracts should look something like:

100 zones have been minted.
  Data for zone 1:  data:application/json;base64,eyJuYW1lIjogIlpvbmUgMSIsImRlc2NyaXB0aW9uIjogIkRvd25zdHJlYW0gWm9uZSAjMSIsImltYWdlIjogImh0dHBzOi8vYXNzZXRzLmRvd25zdHJlYW0uZ2FtZS96b25lLzEucG5nIiwiYXR0cmlidXRlcyI6IFt7InRyYWl0X3R5cGUiOiAiTG9jYXRpb24iLCAidmFsdWUiOiAiMTU5NS02Mi44MzQuMDI2NCJ9LHsidHJhaXRfdHlwZSI6ICJHb29UeXBlIiwgInZhbHVlIjogIkVjaG9waGFnaWMgU3dhcm0ifSx7InRyYWl0X3R5cGUiOiAiVGlsZVJvdGF0aW9uIiwgInZhbHVlIjogIjc4MCJ9LHsidHJhaXRfdHlwZSI6ICJIaXN0b3JpY2FsR292ZXJuYW5jZSIsICJ2YWx1ZSI6ICJQb3N0LVNjYXJjaXR5IFRlY2hub3JlY2x1c2lvbiJ9XX0=
  Data for zone 42:  data:application/json;base64,eyJuYW1lIjogIlpvbmUgNDIiLCJkZXNjcmlwdGlvbiI6ICJEb3duc3RyZWFtIFpvbmUgIzQyIiwiaW1hZ2UiOiAiaHR0cHM6Ly9hc3NldHMuZG93bnN0cmVhbS5nYW1lL3pvbmUvNDIucG5nIiwiYXR0cmlidXRlcyI6IFt7InRyYWl0X3R5cGUiOiAiTG9jYXRpb24iLCAidmFsdWUiOiAiNDkxNy0zMC44MDEuMzQ4OCJ9LHsidHJhaXRfdHlwZSI6ICJHb29UeXBlIiwgInZhbHVlIjogIlBoYXJtYWNldXRpY2FsIFBhc3RlIn0seyJ0cmFpdF90eXBlIjogIlRpbGVSb3RhdGlvbiIsICJ2YWx1ZSI6ICI3MjAifSx7InRyYWl0X3R5cGUiOiAiSGlzdG9yaWNhbEdvdmVybmFuY2UiLCAidmFsdWUiOiAiRXgtaHVtYW4gUGFuZ2FsYWN0aWMgU3RyaXAgTWluaW5nIn1dfQ==

It is expected that you get the same output as this.

Resolves

@ldunnplaymint ldunnplaymint merged commit 2d71cac into main May 2, 2024
3 checks passed
@ldunnplaymint ldunnplaymint deleted the fix-zone-traits-bug branch May 2, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants