expose item data to client #1401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItemKind contracts can SET_DATA_ITEM just like BuildingKind contracts can SET_DATA_BUILDING to let them store data on-chain and read back in the client.... however we were not previously exposing the item data to the plugins so it was useless. this exposes the item data so that plugins can do interesting stuff with it. it updates the cocktail hut so that so "sips" are no longer just a client-local thing and are now a globally shared on-chain counter of all sips ever by everyone. somewhat hilariously though, there's a bug in the implementation of ITEM_USE that means you can only "use" items that are in either bag-0-slot-0 or bag-1-slot-1 😂 ... so that's a bit annoying
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
ItemKind contracts can
SET_DATA_ITEMjust like BuildingKind contracts canSET_DATA_BUILDINGto let them store data on-chain and read back in the client.... however we were not previously exposing the item data to the plugins so it was useless.this exposes the item data so that plugins can do interesting stuff with it.
it updates the cocktail hut so that so "sips" are no longer just a client-local thing and are now a globally shared on-chain counter of all sips ever by everyone.
somewhat hilariously though, there's a bug in the implementation of ITEM_USE that means you can only "use" items that are in either bag-0-slot-0 or bag-1-slot-1 😂 ... so that's a bit annoying and I had to make the cocktail plugin ask you to move the cocktail before using it
issue raised for that #1400 but it would be a contract change so not possible to fix quickly