-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ds-cli: applying ItemKind and BuildingKind manifests #504
Merged
+3,491
−617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
first pass at using solc-js + DEPLOY_KIND_IMPLEMENTATION action to allow deploying building kind implementation contract from ds-cli via a game action we want this so we can allow people to deploy via the sequencer without needing a seperate token and using their player account at this stage there are assumptions being made about project structure still being forge-shaped and you need to pass a ton of cli args ... but this gets the basics in place
it takes alot of cli args to deploy a building and this isn't very repeatable ... to address this we add a declarative "manifest" for describing deployment of ItemKind and BuildingKind enabling deploying multiple preconfigured things in one go. sometimes you don't know the id of an item before you have deployed it, to address this you can reference a not-yet-deployed item by name, so long as the name references another kind from the same manifest
allows for an easy way to get external compiler / tooling working for anything that supports the remappings.txt format (solc, vscode, forge)
ldunnplaymint
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
apply
BuildingKind and ItemKind extensions via YAML manifestsds get --help
)ds get items
ds get units
...etcds config get-remappings > remappings.txt
- this is a quick way to keep tools like solc / vscode / forge happy with the magic@ds
solidity importexample deploying a BuildingKind + Item
There is a couple of example manifests in ./cli/test/examples/ which can have a look at and apply via
known issues