Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Towards 2.0 #13

Merged
merged 34 commits into from
Feb 28, 2024
Merged

Towards 2.0 #13

merged 34 commits into from
Feb 28, 2024

Conversation

jensens
Copy link
Member

@jensens jensens commented Jan 22, 2024

Some unfortunately breaking changes to unify the experience and simplify some tasks.

Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.rst files look good. Thank you! Someone else should review and approve the code.

@jensens
Copy link
Member Author

jensens commented Jan 22, 2024

This needs some testing with real configurations, which I will do in the next days. If anyone else likes to try it, go ahead (I expect bugs).

@jensens
Copy link
Member Author

jensens commented Jan 23, 2024

Fixed and verified with a project config.

remove beta note - its not true anymore
@jensens jensens marked this pull request as ready for review February 22, 2024 16:38
@mliebischer
Copy link
Contributor

Hi Jens,

the problem with the boolean values for the debug_mode option also kicked my butt. In v1 I could only set the option to on, if you define the value as a string, like debug_mode: "True". Before i tried values like True, true, on, etc.. The problem went undetected for a long time until I tried PrintingMailHost which obvious relies on the debug mode. Glad you fixed it here. 👍

While investigating the problem, I found a few odds and ends that could possibly be fixed quickly. I checked the variables in the template files and also the pre and post hook scripts. But some variables seem to be unused/not yet implemented but mentioned in the README.md.

Defined in cookiecutter.json, but never used or mentioned:

  • db_relstorage_orcale_user
  • db_relstorage_orcale_password
  • db_relstorage_orcale_dsn
  • deprecation_warnings

Defined in cookiecutter.json and never used, but documented in README.md:

  • profile_repoze_log_filename
  • profile_repoze_cachegrind_filename
  • profile_repoze_discard_first_request
  • profile_repoze_path
  • profile_repoze_flush_at_shutdown
  • profile_repoze_unwind

Looks like the latter values have been hardcoded in the template:

{%- if cookiecutter.profile_repoze == "True" %}
[filter:profile]
use = egg:repoze.profile
log_filename = {{ cookiecutter.location_log }}/profile-repoze-instance.raw
cachegrind_filename = {{ cookiecutter.location_log }}/profile-repoze-cachegrind.out.instance
discard_first_request = true
path = /__profile__
flush_at_shutdown = true
unwind = false
{%- endif %}

Greetings,
Marcel

@jensens
Copy link
Member Author

jensens commented Feb 28, 2024

@mliebischer thanks! I corrected/added/removed the parts you mentioned.

@jensens jensens merged commit 2dd1f2b into main Feb 28, 2024
@jensens jensens deleted the towards-2.0 branch February 28, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants