Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrong handling of blob-cache-size #24

Merged
merged 2 commits into from
Jul 1, 2024
Merged

fix wrong handling of blob-cache-size #24

merged 2 commits into from
Jul 1, 2024

Conversation

jensens
Copy link
Member

@jensens jensens commented Jul 1, 2024

No description provided.

@jensens jensens force-pushed the fix-blob-cache-size branch 5 times, most recently from 6fb49a0 to 126ff60 Compare July 1, 2024 15:04
@jensens jensens force-pushed the fix-blob-cache-size branch from 126ff60 to f25eba2 Compare July 1, 2024 15:57
@jensens jensens force-pushed the fix-blob-cache-size branch from 7806059 to 9e4c1d5 Compare July 1, 2024 16:08
@jensens jensens merged commit e2a7fe6 into main Jul 1, 2024
@jensens jensens deleted the fix-blob-cache-size branch July 1, 2024 16:10
@gogobd
Copy link
Contributor

gogobd commented Jul 2, 2024

Are both variables necessary (db_blob_mode and db_blobs_mode)?

"db_blob_mode": ["shared", "cache"],
"db_blobs_mode": ["","shared", "cache"],

@jensens
Copy link
Member Author

jensens commented Jul 4, 2024

Are both variables necessary (db_blob_mode and db_blobs_mode)?

"db_blob_mode": ["shared", "cache"],
"db_blobs_mode": ["","shared", "cache"],

db_blobs_mode is BBB only and no longer needed. therefore it has an empty string as default.

@gogobd
Copy link
Contributor

gogobd commented Jul 4, 2024

I see! That's "backwards compatible", then... I see it's already merged. All good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants