Fix typos in docs and deprecation: zcml_package_metas and load_zcml. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix typo in docs: it is not `zcml_package_meta` singular, but `zcml_package_metas` plural. I tried the singular, but it was not working, so had to dive into the code. - Fix typo in deprecation warning: there was never a `zcml` dict setting, only `load_zcml`. I kept seeing a deprecation warning that I should not be using a `zcml` dict, but I was not actually using it, so I never knew what or where to fix. And the setting is not actually removed, but it is deprecated. Changed the warning accordingly.
stevepiercy
requested changes
Aug 30, 2024
Co-authored-by: Steve Piercy <[email protected]>
stevepiercy
approved these changes
Aug 30, 2024
Suggestion by @stevepiercy.
|
Approved again! OK by me to merge, unless you want to wait for @jensens to review, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typo in docs: it is not
zcml_package_metasingular, butzcml_package_metasplural. I tried the singular, but it was not working, so had to dive into the code.Fix typo in deprecation warning: there was never a
zcmldict setting, onlyload_zcml. I kept seeing a deprecation warning that I should not be using azcmldict, but I was not actually using it, so I never knew what or where to fix. And the setting is not actually removed, but it is deprecated. Changed the warning accordingly.