Keys validation #47
Merged
Keys validation #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edublancas
requested changes
Feb 13, 2023
edublancas
requested changes
Feb 14, 2023
edublancas
approved these changes
Feb 15, 2023
|
lgtm. can you rebase? there are some conflicts |
what conflicts? It looks like this branch is up to date with the main. |
|
Ah, right. I got confused because of this: but it still allowed me to squash |
|
released in 0.2.6 https://pypi.org/project/ploomber-core/0.2.6/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Keys validation added to core.
The original code is taken from ploomber.
This will help us to validate a sequence of inputs to a function and raise a meaningful error message to the user with suggested keys.
Issue ticket number and link
Closes
Checklist before requesting a review
📚 Documentation preview 📚: https://ploomber-core--47.org.readthedocs.build/en/47/