Skip to content
This repository was archived by the owner on Feb 28, 2025. It is now read-only.

Regression quickstart #157

Merged
merged 20 commits into from
Jan 4, 2023
Merged

Conversation

neelasha23
Copy link
Contributor

@neelasha23 neelasha23 commented Dec 30, 2022

closes #154 #155 #159

@coveralls
Copy link

coveralls commented Dec 30, 2022

Pull Request Test Coverage Report for Build 3821976137

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 13 of 13 (100.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 94.287%

Files with Coverage Reduction New Missed Lines %
src/sklearn_evaluation/plot/regression.py 3 95.77%
Totals Coverage Status
Change from base Build 3803034901: 0.2%
Covered Lines: 2426
Relevant Lines: 2573

💛 - Coveralls

@neelasha23 neelasha23 requested a review from edublancas January 4, 2023 18:36
Examples
--------
.. plot:: ../examples/prediction_error.py

"""

deprecated.parameter_deprecated(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test for this (https://docs.pytest.org/en/7.1.x/how-to/capture-warnings.html#warns)

also, the deprecation will happen in two major versions to that'd be 0.10, I think since we recently release this, let's remove it in 0.9

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • We've added links to the intro.md page, include this guide as well in it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So deprecation in 0.9 and removal in 0.10?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deprecation is fine 0.8.6, removal in 0.9

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in intro.md @idomic

@edublancas edublancas merged commit a7da3de into ploomber:master Jan 4, 2023
@edublancas
Copy link
Contributor

merged, please check the live docs in a few mins to see if all looks good! @neelasha23

@neelasha23
Copy link
Contributor Author

looking good!

@idomic
Copy link
Contributor

idomic commented Jan 4, 2023

Nice job!

@neelasha23 neelasha23 deleted the reg_quickstart branch January 6, 2023 06:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prediction error plot to support pandas Series object
4 participants