-
Notifications
You must be signed in to change notification settings - Fork 53
Conversation
Pull Request Test Coverage Report for Build 3821976137Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Examples | ||
-------- | ||
.. plot:: ../examples/prediction_error.py | ||
|
||
""" | ||
|
||
deprecated.parameter_deprecated( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test for this (https://docs.pytest.org/en/7.1.x/how-to/capture-warnings.html#warns)
also, the deprecation will happen in two major versions to that'd be 0.10
, I think since we recently release this, let's remove it in 0.9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- We've added links to the
intro.md
page, include this guide as well in it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So deprecation in 0.9 and removal in 0.10?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deprecation is fine 0.8.6, removal in 0.9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in intro.md @idomic
merged, please check the live docs in a few mins to see if all looks good! @neelasha23 |
looking good! |
Nice job! |
closes #154 #155 #159