Skip to content
This repository was archived by the owner on Feb 28, 2025. It is now read-only.

input validation added #291

Merged
merged 6 commits into from
Feb 21, 2023

Conversation

yafimvo
Copy link
Contributor

@yafimvo yafimvo commented Feb 16, 2023

Describe your changes

Key validator with suggestions added to grid_search.

The allowed keys for change are:

"n_estimators",
"criterion",
"max_depth",
"max_features",
"min_samples_split",
"min_samples_leaf"

The allowed keys for kind are: bar and line

Issue ticket number and link

Closes #53

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added thorough tests (when necessary).
  • I have added the right documentation in the docstring and changelog (when needed)

📚 Documentation preview 📚: https://sklearn-evaluation--291.org.readthedocs.build/en/291/

@coveralls
Copy link

coveralls commented Feb 16, 2023

Pull Request Test Coverage Report for Build 4234699851

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 16 of 16 (100.0%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 94.016%

Files with Coverage Reduction New Missed Lines %
src/sklearn_evaluation/util.py 2 94.31%
src/sklearn_evaluation/plot/grid_search.py 3 97.37%
Totals Coverage Status
Change from base Build 4197759914: -0.1%
Covered Lines: 3048
Relevant Lines: 3242

💛 - Coveralls

@edublancas
Copy link
Contributor

if ready, please request the review

@yafimvo yafimvo requested a review from edublancas February 16, 2023 21:16
@yafimvo yafimvo requested a review from edublancas February 20, 2023 10:32
@edublancas edublancas merged commit 0669631 into ploomber:master Feb 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grid_search error log should be more specific
3 participants