-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial actions #3624
Open
stephencelis
wants to merge
5
commits into
main
Choose a base branch
from
initial-actions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Initial actions #3624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is common to send an action to a store when it is first created to kick off some long-living effects. While many utilize the `onAppear` view modifier for this work, we can simplify things by making the store's initializer a little more powerful.
mbrandonw
approved these changes
Mar 14, 2025
mschonvogel
reviewed
Mar 19, 2025
@@ -175,6 +177,9 @@ public final class Store<State, Action> { | |||
initialState: initialState, | |||
reducer: reducer.dependency(\.self, dependencies) | |||
) | |||
if let initialAction = initialAction() { | |||
send(initialAction) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can we send initial actions to stores created by store.scope(…)
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. It's rather uncommon outside of tests to use the store's initialiser directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is common to send an action to a store when it is first created to kick off some long-living effects. While many utilize the
onAppear
view modifier for this work, we can simplify things by making the store's initializer a little more powerful.