Add hydrocannon #10
Merged
Add hydrocannon #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 for switching to Don't Android and iOS version differently? My phone (Android) has 0.107.1, (no updates available) so I'm not sure where 0.108.2 came from. Also, the latest APK from today shows 0.109.2, leading me to be even more confused on how we assign version numbers in this repository. |
|
Lets discuss this in #11. This seems to be a bigger issue |
|
While the discussion in #11 is ongoing, can we go ahead and get this merged in? (now that the event is over, I'd like Hydro Cannon in my metadata) |
|
Do not see a problem with that. @dominicbarnes |
BrunnerLivio
approved these changes
Jul 9, 2018
|
Can we reduce number of approvers to 1 as well?
…On Mon, Jul 9, 2018, 9:35 AM Livio Brunner ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#10 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAX4gHgDzxjHmM0_mZD9rFhq9hGOEsKDks5uE4ZOgaJpZM4VB1vN>
.
|
|
@celandro done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still don't like us trying to version based off this weird Niantic versioning scheme.
yyyymmdd seems much easier but if there is a place for me to find out what the version number would be today I guess that would be ok too.