Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing loki-mixin.annotations and pyroscope-mixin.annotations in respective _helpers.yaml #1004

Merged
merged 2 commits into from
Mar 20, 2025

Conversation

sebbbastien
Copy link
Contributor

@sebbbastien sebbbastien commented Mar 8, 2025

This pull request includes updates to the loki-mixin and pyroscope-mixin Helm charts. The most important changes include version bumps and the addition of common annotations.

Version updates:

Annotations:

Summary by CodeRabbit

  • New Features
    • Upgraded the Helm chart versions for both Loki and Pyroscope mixins, reflecting new releases.
    • Introduced support for custom annotations in both mixins, enabling flexible configuration of additional annotations via chart values.

Copy link

coderabbitai bot commented Mar 8, 2025

Walkthrough

The update increments the version numbers for the Loki and Pyroscope mixin Helm charts and introduces new helper templates for both. These templates include functions that check for additional annotations specified in the values and convert them to YAML format. The changes do not alter existing behavior but expand the functionality of the charts to support custom annotations.

Changes

File(s) Change Summary
charts/loki-mixin/Chart.yaml
charts/pyroscope-mixin/Chart.yaml
Updated Helm chart version numbers: Loki mixin from 1.9.0 to 1.10.0; Pyroscope mixin from 1.5.0 to 1.6.0.
charts/loki-mixin/templates/_helpers.tpl
charts/pyroscope-mixin/templates/_helpers.tpl
Added new template definitions (loki-mixin.annotations and pyroscope-mixin.annotations) to check for and render additionalAnnotations as YAML.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant HelmTemplate
    participant RenderEngine
    participant Deployer

    User->>HelmTemplate: Provide values including additionalAnnotations
    HelmTemplate->>RenderEngine: Convert additionalAnnotations to YAML
    RenderEngine-->>HelmTemplate: Return YAML formatted annotations
    HelmTemplate->>Deployer: Inject annotations into manifest
    Deployer-->>User: Deploy resource with custom annotations
Loading

Poem

I'm a rabbit with a joyous tune,
Hopping through YAML beneath the moon.
New annotations now join the dance,
In charts and code they find their chance.
With each version hop and friendly wink,
My code adventures make us all think!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Free

📥 Commits

Reviewing files that changed from the base of the PR and between f487193 and f2f244c.

📒 Files selected for processing (4)
  • charts/loki-mixin/Chart.yaml (1 hunks)
  • charts/loki-mixin/templates/_helpers.tpl (1 hunks)
  • charts/pyroscope-mixin/Chart.yaml (1 hunks)
  • charts/pyroscope-mixin/templates/_helpers.tpl (1 hunks)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@dosubot dosubot bot added the area/helm Helm label Mar 8, 2025
@nlamirault nlamirault added status/review_needed The issue or PR needs to be reviewed priority/high After critical issues are fixed, these should be dealt with before any further issues kind/bug Categorizes issue or PR as related to a bug lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. labels Mar 20, 2025
@nlamirault nlamirault merged commit 9cc8a3d into portefaix:master Mar 20, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm Helm kind/bug Categorizes issue or PR as related to a bug lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/high After critical issues are fixed, these should be dealt with before any further issues status/review_needed The issue or PR needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants