-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing loki-mixin.annotations and pyroscope-mixin.annotations in respective _helpers.yaml #1004
Conversation
WalkthroughThe update increments the version numbers for the Loki and Pyroscope mixin Helm charts and introduces new helper templates for both. These templates include functions that check for additional annotations specified in the values and convert them to YAML format. The changes do not alter existing behavior but expand the functionality of the charts to support custom annotations. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant HelmTemplate
participant RenderEngine
participant Deployer
User->>HelmTemplate: Provide values including additionalAnnotations
HelmTemplate->>RenderEngine: Convert additionalAnnotations to YAML
RenderEngine-->>HelmTemplate: Return YAML formatted annotations
HelmTemplate->>Deployer: Inject annotations into manifest
Deployer-->>User: Deploy resource with custom annotations
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (4)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This pull request includes updates to the
loki-mixin
andpyroscope-mixin
Helm charts. The most important changes include version bumps and the addition of common annotations.Version updates:
charts/loki-mixin/Chart.yaml
: Updated the version from1.9.0
to1.10.0
.charts/pyroscope-mixin/Chart.yaml
: Updated the version from1.5.0
to1.6.0
.Annotations:
charts/loki-mixin/templates/_helpers.tpl
: Added a new templateloki-mixin.annotations
for common annotations.charts/pyroscope-mixin/templates/_helpers.tpl
: Added a new templatepyroscope-mixin.annotations
for common annotations.Summary by CodeRabbit