-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: SASL (SCRAM-SHA-256) authentication #631
base: main
Are you sure you want to change the base?
Conversation
d0d2e6b
to
9882137
Compare
Thank you for this. I'll review it asap. |
Hey @levkk! Just checking back in here. Do you have an idea of when you'll be able to get to this? Thanks! |
Hi. Thank you for the PR. I haven't forgotten about it, I'll try to review it sometime this weekend or early next week. Please feel free to ping me again if I don't get back to you by then. |
@rkrishn7: Nice! Any progress on this PR? Linked to: |
Hi! This would be a really nice feature, ➕1 to get this in. Thank you to author and reviewers. |
Hi, All my PostgreSQL database baseline the scram-sha-256, this feature very useful. |
This would be really helpful. Apologies for the ping @levkk but have you been able to review this yet? |
I tried building this PR and testing it and ran into an error when actually using |
Sorry for pinging, but this is the only feature missing for us to migrate our entire stack to pgcat instead of pgbouncer |
Is there a beta 2.0 possibly coming out soon?
…On Sun, May 19, 2024 at 11:31 AM Sergio Moreno ***@***.***> wrote:
Sorry for pinging, but this is the only feature missing for us to migrate
our entire stack to pgcat instead of pgbouncer
—
Reply to this email directly, view it on GitHub
<#631 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMWOHWCCONTS4QWHVZCQSTZDDAU7AVCNFSM6AAAAAA6VLJPOWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJZGI3TMNJQHA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Working on 2.0 as we speak. Will have some more news soon. |
Same here with me. pgcat has some very useful features that are a huge advantage over pgbouncer but pgbouncer has a lot more options on the auth front. scram-sha-256 is a huge piece of that and would love to see it included in pcat. Has there been any progress on this PR? |
Any news on this MR ? |
@levkk Any news on this? SASL is highly recommended. Also, this would allow running pgcat with auth_query as a proxy. |
This PR implements SCRAM-SHA-256 SASL mechanism for client <> proxy authentication
Notes for reviewer:
scram
module. However, it may be best to sequence it out into subsequent PRs for review purposesOpen Questions:
Closes #624