Fix default_role
being ignored when query_parser_enabled
was false
#847
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
default_role
was ignored whenquery_parser_enabled
was set to false, this was becauseupdate_pool_settings
does not populate active_role field inquery_router
struct. The fix is simple, I just set it when the router is configured for the first time.Note that as of this, what we say in docs:
is incorrect, because without the fix (and
query_parser_enabled
set to false), this is always treated asany
(which touches the primary as well as the replicas).