-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pq switch to reports [Currently on top of report test format] #1182
base: report_test_format
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I am ok with these changes, just some details about the messages content
1e6e550
to
c1d623d
Compare
|
Unless Sonar that wants you to replace |
This is not a good idea. busID is used in the string template. It is better to be able to check visually that the parameter is same as the one in the template. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this PR should not have to deal with rounding.
rounding issue will be addressed by #1187.
Once we have new powsybl-core RC we will be able to finalize this PR
Good point. I'll add the need rc-core tag and see how the reports look like with the new core behaviour. |
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
… by users Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
38adfa5
to
f05c320
Compare
@jeandemanged Done. Note that #1187 applies only to testing. The underlying core PR powsybl/powsybl-core#3317, just allows to define variable formatters when tunring reports into Strings. The formatters may take advantage of the Unit. So I added a Unit to the new messages, when it makes sense. |
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Report PQ/PV switchs
What is the current behavior?
Only summary of switches are reported
Details are only logged at trace level.
What is the new behavior (if this is a feature change)?
Under the summary, a list of nodes with individual changes are reported.
Does this PR introduce a breaking change or deprecate an API?