[WIP] for limit reduction, duration criteria should depend on next limit's duration #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Didier Vidal <[email protected]>
|
|
I put it in WIP time to verify a few things. |
vidaldid-rte
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Limit reduction based on acceptable duration criteria should be applied based on the duration of the next limit.
Usually, the acceptable duration displayed in security analysis is the duration of the next limit.
When a reduction is applied to all limits with an acceptable duration of 5 minutes or less,
the expectation is that he reduction is applied also to the previous limit (with a duration just higher than 5 minutes)
so that the operator is warned in advance.
What is the current behavior?
Reduction is applied to the limit with duration in range of the criteria. But this has no effect in term of detected the violation of the previous limit earlier.
What is the new behavior (if this is a feature change)?
Reduction is applied to the limit with duration in range of the criteria, but also to the previous limit.
In case two reductions appli to the same limit, the stronger reduction is used
(previously, the reduction declared last was applied)
Does this PR introduce a breaking change or deprecate an API?