Refactor access to branch limits when detecting limit violations #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: p-arvy <[email protected]>
Signed-off-by: p-arvy <[email protected]>
Signed-off-by: p-arvy <[email protected]>
Signed-off-by: Hadrien <[email protected]>
|
Hadrien-Godard
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No, but the development is based on the collaborative work of #1169 , aiming to improve the performance of the fast DC SA.
What kind of change does this PR introduce?
The access to branch limits is refactored, for better performances.
Does this PR introduce a new Powsybl Action implying to be implemented in simulators or pypowsybl?
What is the current behavior?
The branch limits are stored in Maps, indexed by
LimitType.What is the new behavior (if this is a feature change)?
There is a list of limits for each
LimitType. Some method references are also replaced by lambdas.With this refactoring, the time spent on detection of limit violations is reduced, improving the performances of the fast DC SA.
Same with slow DC SA.
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: