Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case for attribute name transformation (#199) #207

Closed
wants to merge 1 commit into from

Conversation

SukkaW
Copy link

@SukkaW SukkaW commented Dec 12, 2021

This PR adds a full test case set for PR #199.

@gpoitch Would you mind including the change in your PR?

@changeset-bot
Copy link

changeset-bot bot commented Dec 12, 2021

⚠️ No Changeset found

Latest commit: bbe37b5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gpoitch
Copy link
Contributor

gpoitch commented Dec 16, 2021

Could be a good idea. That list from React isn't quite usable as-is.
I think they are using it for other purposes but we can derive a proper list from that.

It has a bunch of duplicates values e.g.:

acceptcharset: 'acceptCharset',
'accept-charset': 'acceptCharset'

And others that aren't attributes e.g. innerHTML.

@SukkaW
Copy link
Author

SukkaW commented Dec 16, 2021

Could be a good idea. That list from React isn't quite usable as-is. I think they are using it for other purposes but we can derive a proper list from that.

It has a bunch of duplicates values e.g.:

acceptcharset: 'acceptCharset',
'accept-charset': 'acceptCharset'

And others that aren't attributes e.g. innerHTML.

Oh, you are right.

So I look into react-dom again, and here is how react test the dom attribute: https://github.com/facebook/react/blob/c88fb49d37fd01024e0a254a37b7810d107bdd1d/packages/react-dom/src/__tests__/ReactDOMAttribute-test.js

But the test cases seem to be limited and might not cover all possible cases.

@gpoitch
Copy link
Contributor

gpoitch commented Dec 16, 2021

@SukkaW SukkaW closed this Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants