Fix: invalid consent strings missing legit interest section causes panic #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR contains 2 fixes:
* The `bytesRequired` amount in `parseBitField` was incorrectly rounded down which could lead to out of bound issue
* There was no test before reading at `legitIntStart+16` which can create out of bound issues with invalid consent strings
It also adds 3 tests:
* Validate the correct processing of `bytesRequired` in `parseBitField`
* Proof of concept that allows the previously unfixed code to crash:
* with a crafted consent string going through the initial `parseRangeSection`
* with a crafted consent string going through the initial `parseBitField`
bsardo
approved these changes
Nov 28, 2023
bsardo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains 2 fixes:
bytesRequiredamount inparseBitFieldwas incorrectly rounded down which could lead to out of bound issuelegitIntStart+16which can create out of bound issues with invalid consent stringsIt also adds 3 tests:
bytesRequiredinparseBitFieldparseRangeSectionparseBitField