Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Adapter: Pixad - Admatic alias #4214

Merged
merged 78 commits into from
Mar 13, 2025
Merged

Conversation

bakicam
Copy link
Contributor

@bakicam bakicam commented Feb 14, 2025

@bsardo bsardo added the adapter label Feb 14, 2025
@bsardo
Copy link
Collaborator

bsardo commented Feb 25, 2025

@pm-jaydeep-mohite can you please review?

@bsardo bsardo self-assigned this Feb 25, 2025
@@ -0,0 +1,3 @@
aliasOf: "admatic"
maintainer:
email: "[email protected]"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sent an email please respond as received

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pm-jaydeep-mohite This email has been replied to

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

email id is confirmed

@@ -0,0 +1,3 @@
aliasOf: "admatic"
maintainer:
email: "[email protected]"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this email id correct ?
Got Delivery Status Notification (Failure) while sending verification email

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pm-jaydeep-mohite This email address is correct. Could you try again?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still getting same error,
@bsardo could you please verify this email id ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@farukcam I'm getting a Delivery Status Notification (Failure) error when trying to contact this email address. Please provide a different email address or take the necessary steps so that we can reach you at this address.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsardo We fixed the problem. Can you try again?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@farukcam I resent it. Please respond to the email with "received".

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed receipt.

przemkaczmarek
przemkaczmarek previously approved these changes Mar 7, 2025
Copy link
Collaborator

@bsardo bsardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move netaddiction to a separate PR. We prefer to introduce all new adapters and aliases in their own dedicated PRs to keep the change log clean.

@@ -0,0 +1,3 @@
aliasOf: "admatic"
maintainer:
email: "[email protected]"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@farukcam I'm getting a Delivery Status Notification (Failure) error when trying to contact this email address. Please provide a different email address or take the necessary steps so that we can reach you at this address.

@farukcam
Copy link
Contributor

Please move netaddiction to a separate PR. We prefer to introduce all new adapters and aliases in their own dedicated PRs to keep the change log clean.

@bsardo What should I do for this?

@farukcam
Copy link
Contributor

Please move netaddiction to a separate PR. We prefer to introduce all new adapters and aliases in their own dedicated PRs to keep the change log clean.

@bsardo We removed the yaml files

@bsardo
Copy link
Collaborator

bsardo commented Mar 11, 2025

Please move netaddiction to a separate PR. We prefer to introduce all new adapters and aliases in their own dedicated PRs to keep the change log clean.

@bsardo We removed the yaml files

Thank you for moving it to another PR.

@bsardo
Copy link
Collaborator

bsardo commented Mar 11, 2025

PR: prebid/prebid.github.io#4130

@farukcam can you please open a new docs PR that indicates that pbs is supported by setting it to true and then include a link to that PR here?

@farukcam
Copy link
Contributor

@bsardo The following PR has made pbs true.

PR: prebid/prebid.github.io#5232

@bsardo bsardo merged commit b2efcdf into prebid:master Mar 13, 2025
4 checks passed
scr-oath pushed a commit to scr-oath/prebid-server that referenced this pull request Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants