Connatix: Enhance endpoint with DC #4219
Merged
+724
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code coverage summaryNote:
connatixRefer here for heat map coverage report |
monicaroxanabota
force-pushed
the
master
branch
from
802ac7b to
921044b
Compare
Code coverage summaryNote:
connatixRefer here for heat map coverage report |
Code coverage summaryNote:
connatixRefer here for heat map coverage report |
karimMourra
approved these changes
Feb 26, 2025
ccorbo
previously approved these changes
Mar 10, 2025
adapters/connatix/connatix.go
Outdated
Comment on lines
171
to
181
| if strings.HasPrefix(userID, "1-") { | ||
| queryParams.Add("dc", "us-east-2") | ||
| } | ||
|
|
||
| if strings.HasPrefix(userID, "2-") { | ||
| queryParams.Add("dc", "us-west-2") | ||
| } | ||
|
|
||
| if strings.HasPrefix(userID, "3-") { | ||
| queryParams.Add("dc", "eu-west-1") | ||
| } |
There was a problem hiding this comment.
Optional optimization:
if strings.HasPrefix(userID, "1-") {
queryParams.Add("dc", "us-east-2")
} else if strings.HasPrefix(userID, "2-") {
queryParams.Add("dc", "us-west-2")
} else if strings.HasPrefix(userID, "3-") {
queryParams.Add("dc", "eu-west-1")
}There was a problem hiding this comment.
Discussed with the team. Can you please this optimization to the PR?
There was a problem hiding this comment.
Done, I addressed the comment. Thank you!
VeronikaSolovei9
previously approved these changes
Mar 12, 2025
monicaroxanabota
dismissed stale reviews from VeronikaSolovei9 and ccorbo
via
0f78b83
Code coverage summaryNote:
connatixRefer here for heat map coverage report |
|
@monicaroxanabota your tests are failing because of formatting issues in |
Code coverage summaryNote:
connatixRefer here for heat map coverage report |
VeronikaSolovei9
approved these changes
Mar 13, 2025
ccorbo
approved these changes
Mar 14, 2025
scr-oath
pushed a commit
to scr-oath/prebid-server
that referenced
this pull request
Mar 24, 2025
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.