Possible rules prototype #4246
Possible rules prototype #4246
Conversation
| @@ -0,0 +1,53 @@ | |||
| package optimizationmodule | |||
There was a problem hiding this comment.
The real location should be "modules\prebid\optimization" with the package name "optimization".
optimizationmodule/Function.go
Outdated
| } | ||
|
|
||
| // will be used in Build rules trie | ||
| func NewFunction(name string, params []string) Function { |
There was a problem hiding this comment.
This should return an error, to allow the function builders to validate their input and return an error or warning.
optimizationmodule/Function.go
Outdated
|
|
||
| // will be used in Build rules trie | ||
| func NewFunction(name string, params []string) Function { | ||
| switch name { |
There was a problem hiding this comment.
We'll want to make this case insensitive. Recommend converting to lowercase and having all the cases expressed in lowercase too.
optimizationmodule/Function.go
Outdated
| case "setDeviceIP": | ||
| return NewSetDevIp(params) | ||
| default: | ||
| return nil |
There was a problem hiding this comment.
This should be at least a warning, if a function name is not found / supported.
| return "yes", nil | ||
| } | ||
| return "no", nil | ||
| } |
There was a problem hiding this comment.
Looks good. We can make the yes / no constants to reuse in other functions... or should these be "true" and "false"?
|
|
||
| func (sdip *SetDeviceIp) Call(rw *openrtb_ext.RequestWrapper) (string, error) { | ||
| rw.Device.IP = sdip.IP | ||
| return "", nil |
There was a problem hiding this comment.
This will need to use the modifier pattern. Instead of making the change right here, it needs to return a change set mutation.
| type Node struct { | ||
| Function Function | ||
| // string because "rules": [{ "conditions": ["true", "false"], | ||
| Children map[string]*Node |
There was a problem hiding this comment.
Can the nodes be values instead of pointers?
| IP: "0.0.0.0", | ||
| }, | ||
| }} | ||
| err := rules.Execute(rw) |
There was a problem hiding this comment.
The params first need to be extracted, then given to Execute, and then Execute will use the params to locate a node. This will involve some backtracking behavior for defaults.
No description provided.