Run actions workflow jobs on ubuntu-latest #4251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyntaxNode
reviewed
Mar 10, 2025
.github/workflows/release.yml
Outdated
| @@ -21,7 +21,7 @@ jobs: | |||
| check-permission: | |||
| name: Check permission | |||
| if: contains(github.ref, 'refs/heads/master') | |||
| runs-on: ubuntu-latest | |||
| runs-on: ubuntu-22.04 | |||
There was a problem hiding this comment.
There is no reason to change from ubuntu-latest. Please leave these as-is to stay current.
.github/workflows/security.yml
Outdated
| @@ -11,7 +11,7 @@ on: | |||
| jobs: | |||
| build: | |||
| name: Trivy | |||
| runs-on: ubuntu-20.04 | |||
| runs-on: ubuntu-22.04 | |||
There was a problem hiding this comment.
Better to update to ubuntu-latest.
There was a problem hiding this comment.
I can change this and the release job to ubuntu-latest. I'm pretty sure this was a conscious decision though at the time that we made back when we upgraded to 20.04 (#2358) to have them all on the same version as the docker image. That doesn't seem necessary though as we really only need the test suite to run on that version right?
There was a problem hiding this comment.
Discussed offline. All workflows will run on ubuntu-latest going forward.
bsardo
changed the title
VeronikaSolovei9
approved these changes
Mar 21, 2025
guscarreon
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run security, validate and release jobs on ubuntu-latest