Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imds: Rename to advertising #4258

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pratik-chavan-advertising-dot-com
Copy link

@pratik-chavan-advertising-dot-com pratik-chavan-advertising-dot-com commented Mar 12, 2025

Change the adapter code for imds to advertising reflecting the ownership change from iMedia Digital Services to Advertising.com

Other related PRs:
prebid/Prebid.js#12878
prebid/prebid.github.io#5943

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 01cf667

advertising

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/advertising/advertising.go:35:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/advertising/advertising.go:47:	MakeRequests		100.0%
github.com/prebid/prebid-server/v3/adapters/advertising/advertising.go:60:	makeRequest		88.9%
github.com/prebid/prebid-server/v3/adapters/advertising/advertising.go:134:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v3/adapters/advertising/advertising.go:138:	getExtImpObj		85.7%
github.com/prebid/prebid-server/v3/adapters/advertising/advertising.go:157:	MakeBids		100.0%
github.com/prebid/prebid-server/v3/adapters/advertising/advertising.go:195:	getMediaTypeForImp	100.0%
total:										(statements)		94.3%

@bsardo bsardo added the adapter label Mar 14, 2025
@bsardo bsardo changed the title Rename imds adapter to advertising to reflect the ownership change imds: Rename to advertising Mar 17, 2025
@bsardo bsardo self-assigned this Mar 20, 2025
@bsardo
Copy link
Collaborator

bsardo commented Mar 20, 2025

Hi @pratik-chavan-advertising-dot-com. This is considered a breaking change since you are removing support for the bidder codes imds and syncormedia. As a result, this would need to be part of a major release, such as v4.0, which will be released later this year, perhaps in a few months.
If you don't want to wait for the next major release, you should introduce bidder code advertising while continuing to offer support for bidder codes imds and syncormedia for backwards compatibility.
One way this could be achieved is to restore imds.yaml and syncormedia.yaml and declare them as hard aliases of advertising via the aliasOf directive.

@pratik-chavan-advertising-dot-com
Copy link
Author

pratik-chavan-advertising-dot-com commented Mar 24, 2025

Hi @pratik-chavan-advertising-dot-com. This is considered a breaking change since you are removing support for the bidder codes imds and syncormedia. As a result, this would need to be part of a major release, such as v4.0, which will be released later this year, perhaps in a few months. If you don't want to wait for the next major release, you should introduce bidder code advertising while continuing to offer support for bidder codes imds and syncormedia for backwards compatibility. One way this could be achieved is to restore imds.yaml and syncormedia.yaml and declare them as hard aliases of advertising via the aliasOf directive.

@bsardo Thank you so much for the feedback! We would love to get it released sooner for sure. I will make the necessary updates to support backwards compatibility and update the PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants