Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: some more things to get the shell to work in all cases #3321

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: some more things to get the shell to work in all cases #3321

wants to merge 2 commits into from

Conversation

wolfv
Copy link
Member

@wolfv wolfv commented Mar 11, 2025

This adds the following things:

  • instead of === DONE === will look for PIXI_SHELL_ACTIVATION_DONE which might cause less trouble.
  • The select timeout is much shorter which means we should be able to handle signals and other stuff more easily
  • After waiting for 4 seconds, it would put the shell into "active" mode as a fallback.
  • Prints everything after finding the pattern to stdout

@wolfv wolfv mentioned this pull request Mar 11, 2025
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baszalmstra baszalmstra baszalmstra requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wolfv @baszalmstra