-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support preinstalled local pixi #98
Conversation
…ixi-bin are unset
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart from missing windows tests. Can you add them?
WDYT of this change @ruben-arts? This would make it easier for using setup-pixi in corporate environments where the pixi URL is not easily accessible. This would enable using setup-pixi in corporate environments without the need for specifying a custom pixi url every time. |
The tests should now cover Windows and all functionality of my change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the contribution @ytausch
We'll release this together with #87 |
If updating documentation: