Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support preinstalled local pixi #98

Merged
merged 10 commits into from
Apr 15, 2024
Merged

Conversation

ytausch
Copy link
Contributor

@ytausch ytausch commented Apr 12, 2024

@ytausch ytausch marked this pull request as ready for review April 12, 2024 16:37
@ytausch
Copy link
Contributor Author

ytausch commented Apr 12, 2024

@pavelzw

Copy link
Collaborator

@pavelzw pavelzw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from missing windows tests. Can you add them?

@pavelzw
Copy link
Collaborator

pavelzw commented Apr 12, 2024

WDYT of this change @ruben-arts? This would make it easier for using setup-pixi in corporate environments where the pixi URL is not easily accessible. This would enable using setup-pixi in corporate environments without the need for specifying a custom pixi url every time.

@pavelzw pavelzw added the enhancement New feature or request label Apr 13, 2024
@ytausch
Copy link
Contributor Author

ytausch commented Apr 14, 2024

The tests should now cover Windows and all functionality of my change.

Copy link
Collaborator

@pavelzw pavelzw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@ruben-arts ruben-arts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution @ytausch

@ruben-arts ruben-arts merged commit 60414de into prefix-dev:main Apr 15, 2024
117 of 120 checks passed
@pavelzw
Copy link
Collaborator

pavelzw commented Apr 15, 2024

We'll release this together with #87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants