Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify complex grouping column references (#15474) #24711

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Clarify complex grouping column references (#15474) #24711

wants to merge 2 commits into from

Conversation

Carlos-Jauregui
Copy link

@Carlos-Jauregui Carlos-Jauregui commented Mar 12, 2025 •
edited
Loading

Description

Update documentation for complex grouping operations to reflect that ordinal column references are not allowed

Motivation and Context

Clarify complex grouping operation column reference standards
Resolves #15474

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@Carlos-Jauregui
Clarify complex grouping column references (prestodb#15474)
b3994f7 
Update documentation for complex grouping operations (including
GROUPING SETS, CUBE, and ROLLUP) to state that only column names are
allowed as column references. This change removes the ambiguity around
ordinal references, ensuring the docs align with SQL standards and prevent
user confusion.

Resolves: prestodb#15474
@Carlos-Jauregui
Merge pull request #1 from Carlos-Jauregui/fix-complex-grouping-docs
898c505 
Clarify complex grouping column references (prestodb#15474)
@Carlos-Jauregui Carlos-Jauregui requested review from steveburnett, elharo and a team as code owners March 12, 2025 06:21
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Mar 12, 2025 •
edited
Loading

CLA Signed


The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot added the docs label Mar 12, 2025
steveburnett
steveburnett approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Pull branch, local doc build, looks good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveburnett steveburnett steveburnett approved these changes

@elharo elharo Awaiting requested review from elharo elharo is a code owner

@jaystarshot jaystarshot Awaiting requested review from jaystarshot jaystarshot is a code owner automatically assigned from prestodb/committers

Assignees
No one assigned
Labels
docs
Projects
Presto Documentation
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GROUPING SETS ordinal column documentation mis-documented
2 participants
@Carlos-Jauregui @steveburnett