Add ConnectorDeleteTableHandle to ConnectorProtocol #24721
+275
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In PR #24528 we added a new
ConnectorDeleteTableHandle
interface for use inConnectorMetadata::beginDelete
andfinishDelete
. This changes adds a type parameter for ConnectorDeleteTableHandle implementations to theConnectorProtocolTemplate
declaration, with corresponding hooks inConnectorProtocol
for presto_protocol (de)serialization.Motivation and Context
Adding the implementing type as a parameter to
ConnectorProtocolTemplate
is required to correctly serializeConnectorDeleteTableHandle
implementations to native workers.Impact
Any current connectors defining
ConnectorProtocolTemplate
specializations will need to add a type parameter for theConnectorDeleteTableHandle
implementing type. If the connector does not currently handleConnectorDeleteTableHandle
, it can use theNotImplemented
type.Test Plan
No new tests added, as testing the
ConnectorDeleteTableHandle
serialization would require a corresponding implementation to test.Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.
Differential Revision: D70209547