Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ConnectorDeleteTableHandle to ConnectorProtocol #24721

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ghelmling
Copy link
Contributor

@ghelmling ghelmling commented Mar 12, 2025

Description

In PR #24528 we added a new ConnectorDeleteTableHandle interface for use in ConnectorMetadata::beginDelete and finishDelete. This changes adds a type parameter for ConnectorDeleteTableHandle implementations to the ConnectorProtocolTemplate declaration, with corresponding hooks in ConnectorProtocol for presto_protocol (de)serialization.

Motivation and Context

Adding the implementing type as a parameter to ConnectorProtocolTemplate is required to correctly serialize ConnectorDeleteTableHandle implementations to native workers.

Impact

Any current connectors defining ConnectorProtocolTemplate specializations will need to add a type parameter for the ConnectorDeleteTableHandle implementing type. If the connector does not currently handle ConnectorDeleteTableHandle, it can use the NotImplemented type.

Test Plan

No new tests added, as testing the ConnectorDeleteTableHandle serialization would require a corresponding implementation to test.

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

Prestissimo Changes
* Added a type parameter for `ConnectorDeleteTableHandle` implementations to `ConnectorProtocolTemplate`, along with support for (de)serialization of connector-specific types.  Existing native connector implementations defining `ConnectorProtocolTemplate` specializations will need to update their definitions to supply their specific type or use `NotImplemented`.


Hive Connector Changes
* Updated native `HiveConnectorProtocol` to supply `NotImplemented` for `ConnectorDeleteTableHandle` type.


Iceberg Connector Changes
* Updated native `IcebergConnectorProtocol` to supply `NotImplemented` for `ConnectorDeleteTableHandle` type.

Differential Revision: D70209547

@ghelmling ghelmling requested a review from a team as a code owner March 12, 2025 23:50
@facebook-github-bot
Copy link
Collaborator

This pull request was exported from Phabricator. Differential Revision: D70209547

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants