.erb format support

[AlecRust]

Wondering if there's any plans for this plugin to support .erb format?

Prettier already supports .html format but if passed .html.erb it fails.

[kddnewton]

Yeah absolutely! Still working on how to make that work exactly. Currently there isn't a lot of support for templating languages in general. There's some discussion going on w/r/t prettier as a whole, so I'm following that.

[nPaul]

You may bind types "*.html.erb" as "html"
its works for vim

but erb tags like
<% if condition %>
<%= foo %>
<%= foo %>
<%= foo %>
<% end %>

will formatting to
<% if condition %> <%= foo %> <%= foo %> <%= foo %> <% end %>

[kddnewton]

Okay I dug into this a ton today and here's what I've determined: ERB support is going to be hard.

There are a couple of options, I'm going to lay them out here:

1. Use regex and pray. I'm not entirely kidding. I've messed around with this approach (you can see the work on the erb branch). Basically the idea is to replace ERB tags with valid HTML that HTML expects in each node location. You can see that on the erb branch right now where it supports generic tags. It transforms them from <%= foo %> into <prettier> ... ast ... </prettier>. It then replaces that pattern on the printing side. This approach is probably fraught with peril.
2. Extend https://github.com/ikatyang/angular-html-parser to support ERB tags. That's... possible, but I'm not entirely sure it's advisable. I don't have a hankering to tack on something to that parser that really doesn't belong there. From a cursory glance it doesn't look like it supports plugins or anything like that (like babel). Not sure how to proceed with that approach.
3. Write our own ERB parser. Believe it or not, this doesn't actually seem impossible. It already kind of exists with https://github.com/Shopify/better-html. I'm not sure of how feasible it would be to use it, but it definitely seems like an option.

Regardless, I'm going to table this issue for now. I just don't have the bandwidth to work on it right now. I'd be super happy if anyone wanted to really dig into this - I'm sure it would be a rewarding endeavor. Hopefully I'll be able to come back to it at some point.

[kddnewton]

Just for bookkeeping purposes I'm going to close this issue. I talk a little about it in the wiki https://github.com/prettier/plugin-ruby/wiki#do-you-support-erb-files-htmlerb-jserb-etc, and I'm talking to prettier core members about it. Hopefully we'll have something to look at in the future.

[bbugh]

@kddeisz that link is dead (the wiki seems to be inaccessible or gone). Did you post it anywhere else?

[vvo]

@bbugh it's here: https://github.com/prettier/plugin-ruby/blob/master/CONTRIBUTING.md#do-you-support-erb-files-htmlerb-jserb-etc I think it was a mistake.

[ghost]

Would still love to see this in Prettier. It would allow us to reduce the number of formatters we have in our project by 1 which is always great.

[kddnewton]

What are you currently using to format erb?

On Tue, Oct 6, 2020 at 11:23 AM Alan Savage ***@***.***> wrote: Would still love to see this in Prettier. It would allow us to reduce the number of formatters we have in our project by 1 which is always great. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#371 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABG3P3S4LAIX3KEM6SRBOXTSJMY5PANCNFSM4IKMSYHA> .

-- *Kevin D. Deisz* Staff Production Engineer Shopify <https://www.shopify.com/>

[ghost]

Rufo

…

On Tue, Oct 6, 2020, 10:22 AM Kevin Deisz ***@***.***> wrote: What are you currently using to format erb? On Tue, Oct 6, 2020 at 11:23 AM Alan Savage ***@***.***> wrote: > Would still love to see this in Prettier. It would allow us to reduce the > number of formatters we have in our project by 1 which is always great. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > < #371 (comment) >, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/ABG3P3S4LAIX3KEM6SRBOXTSJMY5PANCNFSM4IKMSYHA > > . > -- *Kevin D. Deisz* Staff Production Engineer Shopify <https://www.shopify.com/> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#371 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APRKQYSSKKCUXMIWFOEN2GLSJNG6HANCNFSM4IKMSYHA> .

[kddnewton]

Nice! I didn’t know Rufo had support for ERB. I’ll have to check out how they do it

On Tue, Oct 6, 2020 at 1:37 PM Alan Savage ***@***.***> wrote: Rufo On Tue, Oct 6, 2020, 10:22 AM Kevin Deisz ***@***.***> wrote: > What are you currently using to format erb? > > On Tue, Oct 6, 2020 at 11:23 AM Alan Savage ***@***.***> > wrote: > > > Would still love to see this in Prettier. It would allow us to reduce the > > number of formatters we have in our project by 1 which is always great. > > > > — > > You are receiving this because you were mentioned. > > Reply to this email directly, view it on GitHub > > < > #371 (comment) > >, > > or unsubscribe > > < > https://github.com/notifications/unsubscribe-auth/ABG3P3S4LAIX3KEM6SRBOXTSJMY5PANCNFSM4IKMSYHA > > > > . > > > -- > *Kevin D. Deisz* > Staff Production Engineer > Shopify <https://www.shopify.com/> > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > < #371 (comment) >, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/APRKQYSSKKCUXMIWFOEN2GLSJNG6HANCNFSM4IKMSYHA > > . > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#371 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABG3P3UGPHR2HZEBXPUC5N3SJNIWDANCNFSM4IKMSYHA> .

-- *Kevin D. Deisz* Staff Production Engineer Shopify <https://www.shopify.com/>

[chrisw-]

Just FYI, I use https://github.com/threedaymonk/htmlbeautifier which works ok.

[ianks]

I think it's really close actually! It does not seem to be breaking our HTML at all, just a few small styling nits and i think this could be shipped.

Formatting Inline Ruby

A: If we format a file with this content:

<%= render partial: 'shared/search_header', locals: { search_url: routes.retailers_path } %>

<%= form %>

B: Prettier will output:

<%= render partial: 'shared/search_header', locals: { search_url: routes.retailers_path } %> <%= form %>

This isn't wrong; it's fully syntactically valid. However, I think the A output looks better. Would it make sense to treat the inline ruby <% tags the same way as a br /> is treated, so it will keep the line breaks?

[chrisw-]

https://github.com/adamzapasnik/prettier-plugin-erb

[kevinhq]

https://github.com/adamzapasnik/prettier-plugin-erb

not working on vim. not sure what's wrong.

[Juice10]

https://github.com/adamzapasnik/prettier-plugin-erb currently doesn't support prettier 2.3+ which is kind of a deal breaker for me unfortunately.
More info: adamzapasnik/prettier-plugin-erb#49