Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get rid of 'codename' deps (too heavy) #167

Closed
Weakky opened this issue Dec 13, 2019 · 0 comments · Fixed by #847
Closed

get rid of 'codename' deps (too heavy) #167

Weakky opened this issue Dec 13, 2019 · 0 comments · Fixed by #847
Labels
effort/easy type/improve Something existing is made better, does not affect the interface (example: better error message)

Comments

@Weakky
Copy link
Collaborator

Weakky commented Dec 13, 2019

It's using lodash for whatever reason, we shouldn't have such a heavy dep for something like that 😛

image
@jasonkuhrt jasonkuhrt added type/improve Something existing is made better, does not affect the interface (example: better error message) and removed polish labels Mar 6, 2020
jasonkuhrt added a commit that referenced this issue May 12, 2020
@jasonkuhrt
improve: remove codename dep
59780d3 
closes #167

While this may not seem like an improvement for end-users, but rather an internal refactor, the user-facing part is in how it helps support #119. It turned out that codename uses some dynamic requires that rollup commonjs plugin cannot understand.
@jasonkuhrt jasonkuhrt mentioned this issue May 12, 2020
Merged
jasonkuhrt pushed a commit that referenced this issue May 12, 2020
improve: remove codename dep (#847)
1651b12 
closes #167

While this may not seem like an improvement for end-users, but rather an internal refactor, the user-facing part is in how it helps support #119. It turned out that codename uses some dynamic requires that rollup commonjs plugin cannot understand.

This does mean that users will see a less pretty name when creating new projects in non-empty directories. Very minor thing that we can revisit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/easy type/improve Something existing is made better, does not affect the interface (example: better error message)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

improve: remove codename dep prisma-labs/graphql-framework-experiment
2 participants
@jasonkuhrt @Weakky