Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(website): formatting fixes #2 #1096

Merged
merged 22 commits into from
Jun 25, 2020
Merged

chore(website): formatting fixes #2 #1096

merged 22 commits into from
Jun 25, 2020

Conversation

mhwelander
Copy link
Contributor

No description provided.

@mhwelander mhwelander changed the title Various formatting fixes docs(website): formatting fixes #2 Jun 24, 2020
@@ -3,32 +3,33 @@ title: 'Server'
metaTitle: 'Server'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why even use Server when it is just about Serverless? cc @jasonkuhrt

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or is this the component name?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heya,

So Nexus has a "server" component that can be either in serverful or serverless mode.

For example:

import { server } from 'nexus'

server.middleware() // ... this would work over serverless OR serverful

From a product POV this is still a WIP, we'll see how #782 goes + evolves...

To your question, the guides, it is not that the guide title was intended to match the component name. However, we felt that having two guides serverless and serverful would be confusing. Also a lot of content that applies to one applies to the other (e.g. middleware).

We wanted a single guide for all "server related stuff", and concluded on the name server. Within it, there will be three parts:

  1. serverless only stuff
  2. serverful only stuff
  3. general stuff shared by all modes

Now that you have the context, do you have a suggestion for a better guide name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would write both Schema component and Server component:

image

Further down the nav they are referred to as components:

image

(is 'logging' also a 'logger component')?

@jasonkuhrt jasonkuhrt changed the title docs(website): formatting fixes #2 chore(website): formatting fixes #2 Jun 25, 2020
@mhwelander mhwelander merged commit db1a73d into master Jun 25, 2020
@mhwelander mhwelander deleted the formatting-1 branch June 25, 2020 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants