Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(schema): "use" method to add schema plugins #624

Merged
merged 6 commits into from
Apr 9, 2020

Conversation

jasonkuhrt
Copy link
Member

@jasonkuhrt jasonkuhrt commented Apr 9, 2020

Relates to #514

  • docs
  • tests

@jasonkuhrt jasonkuhrt requested a review from Weakky April 9, 2020 16:21
@@ -428,7 +428,7 @@ todo
import { schema } from 'nexus'
import { connectionFromArray } from 'graphql-relay'

schema.queryType(t => {
schema.queryType((t) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to the PR but that thing looks wrong to me, it should be in a definition block

Copy link
Collaborator

@Weakky Weakky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was an easy one 😄! All good, you actually made me think that I did not think to document the app.use in the API reference

@Weakky
Copy link
Collaborator

Weakky commented Apr 9, 2020

That was an easy one 😄! All good, you actually made me think that I did not think to document the app.use in the API reference

Nevermind, you actually already did it, thanks🙏

@jasonkuhrt jasonkuhrt merged commit a94ed36 into master Apr 9, 2020
@jasonkuhrt jasonkuhrt deleted the feat/use-schema-plugin branch April 9, 2020 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants