fix(start-module): require plugins instead of import

[Weakky]

Description

When using import, ts.transpileModule removes the import if the import is not used.

As the plugin imports are only there to enable tree-shaking (but the plugins aren't used), the imports were removed.

This PR uses require instead, which prevents the imports from being removed

[jasonkuhrt]

But tree-shaking does not work with require. There must be another way.

I don't think there's a problem here. When we get to it, we will support a build where ES Modules are left in tact.

From there, what TS has produced, will get handed off to something like parcel.js.

[Weakky]

But tree-shaking does not work with require.

Ohh, ofc, makes sense 👍

I don't think there's a problem here

Well, the problem right now is that all plugin imports are trimmed out. So if one tries to tree-shake the app, I assume the runtime plugins wouldn't be part of the bundle

[jasonkuhrt]

So if one tries to tree-shake the app, I assume the runtime plugin wouldn't be part of the bundle

Correct, tree-shaking will not work as is. And probably we want to build it in but let it be disabled, overriden, etc.

For example user should be able to adjust their tsconfig and make TS output imports instead of requires.

Don't think we have an issue for this yet, will create it.

[jasonkuhrt]

Actually we do graphql-nexus/nexus#119

[jasonkuhrt]

@Weakky Anything left to discuss or shall we close?

[Weakky]

Let's close 👍