feat(schema): add schema.middleware #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Weakky
commented
Apr 21, 2020
Weakky
commented
- docs
- tests
Weakky
force-pushed
the
feat/schema-middleware
branch
from
756045d to
3e8406a
Compare
jasonkuhrt
approved these changes
Apr 21, 2020
| @@ -83,7 +85,7 @@ export function create(): App { | |||
| } | |||
|
|
|||
| const server = Server.create() | |||
| const schemaComponent = Schema.create() | |||
| const schemaComponent = Schema.create(__state) | |||
There was a problem hiding this comment.
Interesting, I had being going a direction before where schema would have its own state. Your approach reminds me of a react-ish atomic-state idea. Any particular thoughts here or you just did what first came to you?
| @@ -5,7 +5,7 @@ import { mapSettingsToNexusSchemaConfig } from './settings' | |||
| let schema: ReturnType<typeof create> | |||
|
|
|||
| beforeEach(() => { | |||
| schema = create() | |||
| schema = create({ isWasServerStartCalled: false, plugins: [] }) | |||
There was a problem hiding this comment.
Does this part feel like a leak of detail?
| const middleware: SchemaInternal['public']['middleware'] = (fn) => { | ||
| api.public.use( | ||
| NexusSchema.plugin({ | ||
| // TODO: Do we need to expose the name property? |
| // todo if caleld after app start, raise a warning (dev), error (prod) | ||
| // this will require the component having access to some of the | ||
| // framework state. | ||
| if (appState.isWasServerStartCalled === true) { |
There was a problem hiding this comment.
Ahhh this is the key reason to pass down app state, I see. Def. a fair point!
jasonkuhrt
reviewed
Apr 21, 2020
Co-Authored-By: Jason Kuhrt <[email protected]>
Co-Authored-By: Jason Kuhrt <[email protected]>
Weakky
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.